linux-kernel - RE: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9a6d127cdc94f1ba40ce0d2dff78156@ausx13mpc120.AMER.DELL.COM>
Date:   Mon, 16 Oct 2017 13:48:05 +0000
From:   <Mario.Limonciello@...l.com>
To:     <pali.rohar@...il.com>
CC:     <dvhart@...radead.org>, <andy.shevchenko@...il.com>,
        <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>, <luto@...nel.org>,
        <quasisec@...gle.com>, <rjw@...ysocki.net>, <mjg59@...gle.com>,
        <hch@....de>, <greg@...ah.com>, <gnomes@...rguk.ukuu.org.uk>
Subject: RE: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI

> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@...il.com]
> Sent: Monday, October 16, 2017 8:37 AM
> To: Limonciello, Mario <Mario_Limonciello@...l.com>
> Cc: dvhart@...radead.org; andy.shevchenko@...il.com; linux-
> kernel@...r.kernel.org; platform-driver-x86@...r.kernel.org; luto@...nel.org;
> quasisec@...gle.com; rjw@...ysocki.net; mjg59@...gle.com; hch@....de;
> greg@...ah.com; gnomes@...rguk.ukuu.org.uk
> Subject: Re: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI
> 
> On Monday 16 October 2017 13:23:04 Mario.Limonciello@...l.com wrote:
> > > -----Original Message-----
> > > From: Pali Rohár [mailto:pali.rohar@...il.com]
> > > Sent: Monday, October 16, 2017 2:33 AM
> > > To: Limonciello, Mario <Mario_Limonciello@...l.com>
> > > Cc: dvhart@...radead.org; Andy Shevchenko <andy.shevchenko@...il.com>;
> > > LKML <linux-kernel@...r.kernel.org>; platform-driver-x86@...r.kernel.org;
> Andy
> > > Lutomirski <luto@...nel.org>; quasisec@...gle.com; rjw@...ysocki.net;
> > > mjg59@...gle.com; hch@....de; Greg KH <greg@...ah.com>; Alan Cox
> > > <gnomes@...rguk.ukuu.org.uk>
> > > Subject: Re: [PATCH v8 00/15] Introduce support for Dell SMBIOS over WMI
> > >
> > > Hi! Just a small idea, what about including example userspace
> > > application which would use this new API? I think such application can
> > > be useful for documentation purpose to see how this new API should be
> > > used. And in review process other people can point if there would be
> > > some problems with usage.
> > >
> > > I do not know if it is requirement or not for introducing new kernel
> > > API, but still example code is very useful for developers when they
> > > would start to use this new API and correctly.
> > >
> > > --
> > > Pali Rohár
> > > pali.rohar@...il.com
> >
> > Pali,
> >
> > I've produced a small sample application available here:
> > https://github.com/superm1/smbios-wmi-poc
> 
> Simple one-file example application. Great!
> 
> Darren, Greg, Mario, I think it would be better to have this example
> application in tools/ or in Documentation/... What do you think?
> 
> Looking for examples on random github repos is harder and less official
> as part of linux source tree.
> 

If others also agree, I'm fine with including it with the kernel.
Please advise where it should be located.

It was originally a POC made just for my own testing of this API.  
I will probably need to clean it up a little though for wider distribution 
to the kernel so I would prefer to send it in a follow up patch if no other
feedback requiring changes to this series as is.

One possible issue is that it currently uses glib.  Is that OK?