linux-kernel - Re: [PATCH] [media] stk-webcam: Fix use after free on disconnect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171016141331.qyjzz26l567ycdew@paasikivi.fi.intel.com>
Date:   Mon, 16 Oct 2017 17:13:31 +0300
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Bhumika Goyal <bhumirks@...il.com>,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        Joe Perches <joe@...ches.com>, linux-media@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [media] stk-webcam: Fix use after free on disconnect

On Fri, Sep 22, 2017 at 04:48:41PM +0300, Dan Carpenter wrote:
> We free the stk_camera device too early.  It's allocate first in probe
> and it should be freed last in stk_camera_disconnect().
> 
> Reported-by: Andrey Konovalov <andreyknvl@...gle.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> Not tested but these bug reports seem surprisingly straight forward.
> Thanks Andrey!

Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

-- 
Sakari Ailus
sakari.ailus@...ux.intel.com