linux-kernel - Re: Regression in linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2017 16:16:19 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Petri Latvala <petri.latvala@...el.com>
cc:     Yu Chen <yu.c.chen@...el.com>, Juergen Gross <jgross@...e.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Tony Luck <tony.luck@...el.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Alok Kataria <akataria@...are.com>,
        Joerg Roedel <joro@...tes.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Steven Rostedt <rostedt@...dmis.org>,
        Christoph Hellwig <hch@....de>,
        Peter Zijlstra <peterz@...radead.org>,
        Borislav Petkov <bp@...en8.de>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Rui Zhang <rui.zhang@...el.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Len Brown <lenb@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: Regression in linux-next

On Mon, 16 Oct 2017, Petri Latvala wrote:
> On 10/16/2017 03:54 PM, Thomas Gleixner wrote:
> > > Hrm. I completely forgot that this does not dump the buffers of offline
> > > CPUs. So half of the information is missing. So forget the tracer for now.
> > > 
> > > Can you please apply the debug patch below and provide the full dmesg
> > > output?
> > > 
> > > Its going to be too big for LKML so either upload it somewhere or send it
> > > to me in private mail.
> > > 
> > > Note, I removed the BUG_ON, so box might survive suspend/resume but it
> > > should trigger that printout.
> > Forgot to add the counterpart to the clear side. Updated patch below.
> 
> http://paste.debian.net/991048/

Thanks for providing the data! Does the patch below fix the issue?

Thanks,

	tglx

8<---------------

--- a/arch/x86/kernel/apic/vector.c
+++ b/arch/x86/kernel/apic/vector.c
@@ -809,7 +809,7 @@ static void free_moved_vector(struct api
 
 	trace_vector_free_moved(apicd->irq, vector, managed);
 	irq_matrix_free(vector_matrix, cpu, vector, managed);
-	__this_cpu_write(vector_irq[vector], VECTOR_UNUSED);
+	per_cpu(vector_irq, cpu)[vector] = VECTOR_UNUSED;
 	hlist_del_init(&apicd->clist);
 	apicd->prev_vector = 0;
 	apicd->move_in_progress = 0;