linux-kernel - Re: [PATCH v5 7/7] soc: mediatek: pwrap: fixup warnings from coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fa7858f-7a73-1275-f345-24efa48e957c@gmail.com>
Date:   Mon, 16 Oct 2017 17:02:02 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     sean.wang@...iatek.com, robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, linux-mediatek@...ts.infradead.org
Cc:     chen.zhong@...iatek.com, chenglin.xu@...iatek.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 7/7] soc: mediatek: pwrap: fixup warnings from coding
 style



On 10/16/2017 09:07 AM, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> fixup those warnings such as lines over 80 words and parenthesis
> alignment which would be complained by checkpatch.pl.
> 
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---

I already took this patch, please drop from series.

Thanks


>   drivers/soc/mediatek/mtk-pmic-wrap.c | 20 +++++++++++++-------
>   1 file changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 9ac304a..51b8894 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1101,7 +1101,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
>   	/* wait for cipher data ready@...C */
>   	ret = pwrap_wait_for_state(wrp, pwrap_is_pmic_cipher_ready);
>   	if (ret) {
> -		dev_err(wrp->dev, "timeout waiting for cipher data ready@...C\n");
> +		dev_err(wrp->dev,
> +			"timeout waiting for cipher data ready@...C\n");
>   		return ret;
>   	}
>   
> @@ -1496,23 +1497,27 @@ static int pwrap_probe(struct platform_device *pdev)
>   		if (IS_ERR(wrp->bridge_base))
>   			return PTR_ERR(wrp->bridge_base);
>   
> -		wrp->rstc_bridge = devm_reset_control_get(wrp->dev, "pwrap-bridge");
> +		wrp->rstc_bridge = devm_reset_control_get(wrp->dev,
> +							  "pwrap-bridge");
>   		if (IS_ERR(wrp->rstc_bridge)) {
>   			ret = PTR_ERR(wrp->rstc_bridge);
> -			dev_dbg(wrp->dev, "cannot get pwrap-bridge reset: %d\n", ret);
> +			dev_dbg(wrp->dev,
> +				"cannot get pwrap-bridge reset: %d\n", ret);
>   			return ret;
>   		}
>   	}
>   
>   	wrp->clk_spi = devm_clk_get(wrp->dev, "spi");
>   	if (IS_ERR(wrp->clk_spi)) {
> -		dev_dbg(wrp->dev, "failed to get clock: %ld\n", PTR_ERR(wrp->clk_spi));
> +		dev_dbg(wrp->dev, "failed to get clock: %ld\n",
> +			PTR_ERR(wrp->clk_spi));
>   		return PTR_ERR(wrp->clk_spi);
>   	}
>   
>   	wrp->clk_wrap = devm_clk_get(wrp->dev, "wrap");
>   	if (IS_ERR(wrp->clk_wrap)) {
> -		dev_dbg(wrp->dev, "failed to get clock: %ld\n", PTR_ERR(wrp->clk_wrap));
> +		dev_dbg(wrp->dev, "failed to get clock: %ld\n",
> +			PTR_ERR(wrp->clk_wrap));
>   		return PTR_ERR(wrp->clk_wrap);
>   	}
>   
> @@ -1557,8 +1562,9 @@ static int pwrap_probe(struct platform_device *pdev)
>   	pwrap_writel(wrp, wrp->master->int_en_all, PWRAP_INT_EN);
>   
>   	irq = platform_get_irq(pdev, 0);
> -	ret = devm_request_irq(wrp->dev, irq, pwrap_interrupt, IRQF_TRIGGER_HIGH,
> -			"mt-pmic-pwrap", wrp);
> +	ret = devm_request_irq(wrp->dev, irq, pwrap_interrupt,
> +			       IRQF_TRIGGER_HIGH,
> +			       "mt-pmic-pwrap", wrp);
>   	if (ret)
>   		goto err_out2;
>   
>