linux-kernel - Re: tracing, dma-buf: Remove unused trace event dma_fence_annotate_wait_on

Open Source and information security mailing list archives

Message-ID: <CAO_48GEsOyY_18CVgJUbf7xsPk6NyxE38tP+6VhZMkqVBmjCuw@mail.gmail.com>
Date:   Mon, 16 Oct 2017 20:49:11 +0530
From:   Sumit Semwal <sumit.semwal@...aro.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Daniel Vetter <daniel@...ll.ch>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Christian Koenig <christian.koenig@....com>,
        DRI mailing list <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: tracing, dma-buf: Remove unused trace event dma_fence_annotate_wait_on

Hi Steven,

On 16 October 2017 at 20:07, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Mon, 16 Oct 2017 11:15:45 +0200
> Daniel Vetter <daniel@...ll.ch> wrote:
>
>> On Fri, Oct 13, 2017 at 05:27:59PM +0200, Christian König wrote:
>> > Am 13.10.2017 um 16:06 schrieb Steven Rostedt:
>> > > From: Steven Rostedt (VMware) <rostedt@...dmis.org>
>> > >
>> > > Commit e941759c74 ("fence: dma-buf cross-device synchronization") added
>> > > trace event fence_annotate_wait_on, but never used it. It was renamed
>> > > to dma_fence_annotate_wait_on by commit f54d186700 ("dma-buf: Rename
>> > > struct fence to dma_fence") but still not used. As defined trace events
>> > > have data structures and functions created for them, it is a waste of
>> > > memory if they are not used. Remove the unused trace event.
>> > >
>> > > Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
>> >
>> > Reviewed-by: Christian König <christian.koenig@....com>
>>
>> Since you have commit rights to drm-misc I assume you'll push this too.
>>
>
> Will it cause conflict if I pull it through my tree? It's just removing
> unused traecpoints. I added it to my tree already (but haven't pushed
> it to linux-next yet), with the Reviewed by from Christian. Is that OK?
> It shouldn't cause any merge conflicts that Linus can't handle.

I suspect it should be ok; please do feel free to add my
Acked-by: Sumit Semwal <sumit.semwal@...aro.org>
if you wish :)
>
> -- Steve
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Best,
Sumit.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives