linux-kernel - Re: [PATCH] checkpatch: Allow DEFINE_PER_CPU definitions to exceed line length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171016163149.lhgqbmn2oxdcfvaw@lakrids.cambridge.arm.com>
Date:   Mon, 16 Oct 2017 17:32:13 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Joe Perches <joe@...ches.com>
Cc:     daniel.lezcano@...aro.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        marc.zyngier@....com, tglx@...utronix.de,
        ard.biesheuvel@...aro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Allow DEFINE_PER_CPU definitions to exceed
 line length

On Mon, Oct 16, 2017 at 09:12:00AM -0700, Joe Perches wrote:
> Some of the definitions are very long and can't be split
> into multiple lines because ctags is limited.
> 
> Exempt these lines from the line length checks.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

It might make sense to point at commit:

  25528213fe9f75f4 ("tags: Fix DEFINE_PER_CPU expansions")

... for the gory details, but either way:

Acked-by: Mark Rutland <mark.rutland@....com>

Thanks,
Mark.

> ---
>  scripts/checkpatch.pl | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2a8c6c3c1bdb..5fa0f5467d99 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2900,8 +2900,9 @@ sub process {
>  				 $line =~ /^\+\s*#\s*define\s+\w+\s+$String$/) {
>  				$msg_type = "";
>  
> -			# EFI_GUID is another special case
> -			} elsif ($line =~ /^\+.*\bEFI_GUID\s*\(/) {
> +			# More special cases
> +			} elsif ($line =~ /^\+.*\bEFI_GUID\s*\(/ ||
> +				 $line =~ /^\+\s*(?:\w+)?\s*DEFINE_PER_CPU/) {
>  				$msg_type = "";
>  
>  			# Otherwise set the alternate message types