linux-kernel - Re: [PATCH v5] crypto: s5p-sss: Add HASH support for Exynos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2017 18:40:16 +0200
From:   Kamil Konieczny <k.konieczny@...tner.samsung.com>
To:     Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Vladimir Zapolskiy <vz@...ia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] crypto: s5p-sss: Add HASH support for Exynos

Hello Vladimir,

>>[snip]

>> -static struct s5p_aes_dev *s5p_dev;
>> +enum hash_op {
>> +	HASH_OP_UPDATE = 1,
>> +	HASH_OP_FINAL = 2
>> +};
> 
> If this type is not going to be extended, then I'd rather suggest to
> use a boolean correspondent field in the struct s5p_hash_reqctx instead
> of a new introduced type. [...]

In prevoious mail I wrote 'op_final', but this will actually be 'op_update'.

-- 
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland