linux-kernel - Re: [Part1 PATCH v6 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <792fdb90-3416-2f4e-59c1-a203b2ca9b5f@amd.com>
Date:   Mon, 16 Oct 2017 12:46:20 -0500
From:   Brijesh Singh <brijesh.singh@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     brijesh.singh@....com, x86@...nel.org,
        Tom Lendacky <thomas.lendacky@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andy Lutomirski <luto@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [Part1 PATCH v6 02/17] x86/mm: Add Secure Encrypted
 Virtualization (SEV) support


On 10/16/17 11:21 AM, Borislav Petkov wrote:

...

>> +static bool sev_enabled __section(.data) = false;
> You need to run a patch through checkpatch everytime you change it -
> sometimes the warning makes sense, like in this case:
>
> ERROR: do not initialise statics to false
> #73: FILE: arch/x86/mm/mem_encrypt.c:45:
> +static bool sev_enabled __section(.data) = false;


sev_enabled lives in .data section and looking at the objdump it seems
to initialized to zero. So, I think its safe to remove the initialization.

Tom,

Please let me know if you are okay with the changes.

I will do a quick test run and update the patch.