linux-kernel - Re: [PATCH v2 1/3] udf: Fix 64-bit sign extension issues affecting blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57583a28-5683-a650-7a63-01be73c973df@digidescorp.com>
Date:   Mon, 16 Oct 2017 14:20:39 -0500
From:   Steve Magnani <steve.magnani@...idescorp.com>
To:     Jan Kara <jack@...e.cz>
Cc:     Jan Kara <jack@...e.com>, linux-kernel@...r.kernel.org,
        "Steven J . Magnani" <steve@...idescorp.com>
Subject: Re: [PATCH v2 1/3] udf: Fix 64-bit sign extension issues affecting
 blocks > 0x7FFFFFFF

Jan -

On 10/16/2017 09:17 AM, Jan Kara wrote:
> ...
> If you agree with these changes, I'll update your patch and merge it to my
> tree (along with the other two changes which look good to me).
>
>
I think your suggestions are OK. In an ideal world we could work to 
reduce the many signed/unsigned conversions, which make me dizzy. I 
think the ones that really cause problems are large unsigned int values 
which are converted to int and then either to sector_t (except on 32-bit 
systems without LBDAF) or to unsigned long on 64-bit systems.
------------------------------------------------------------------------
  Steven J. Magnani               "I claim this network for MARS!
  www.digidescorp.com              Earthling, return my space modulator!"

  #include <standard.disclaimer>