linux-kernel - Re: [PATCH] xen-netfront, xen-netback: Use correct minimum MTU values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171016.212223.777323721927998324.davem@davemloft.net>
Date:   Mon, 16 Oct 2017 21:22:23 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     boris.ostrovsky@...cle.com
Cc:     wei.liu2@...rix.com, mgamal@...hat.com, netdev@...r.kernel.org,
        xen-devel@...ts.xenproject.org, paul.durrant@...rix.com,
        linux-kernel@...r.kernel.org, vkuznets@...hat.com,
        otubo@...hat.com, cavery@...hat.com, cheshi@...hat.com,
        jgross@...e.com
Subject: Re: [PATCH] xen-netfront, xen-netback: Use correct minimum MTU
 values

From: Boris Ostrovsky <boris.ostrovsky@...cle.com>
Date: Mon, 16 Oct 2017 16:19:07 -0400

> On 10/16/2017 11:05 AM, Wei Liu wrote:
>> On Mon, Oct 16, 2017 at 03:20:32PM +0200, Mohammed Gamal wrote:
>>> RFC791 specifies the minimum MTU to be 68, while xen-net{front|back}
>>> drivers use a minimum value of 0.
>>>
>>> When set MTU to 0~67 with xen_net{front|back} driver, the network
>>> will become unreachable immediately, the guest can no longer be pinged.
>>>
>>> xen_net{front|back} should not allow the user to set this value which causes
>>> network problems.
>>>
>>> Reported-by: Chen Shi <cheshi@...hat.com>
>>> Signed-off-by: Mohammed Gamal <mgamal@...hat.com>
>> Acked-by: Wei Liu <wei.liu2@...rix.com>
>>
>> CC netfront maintainers
> 
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> 
> I can take it via Xen tree unless there are objections.

No problem on my end.