linux-kernel - Re: [PATCH 00/12] of: overlay: clean up device tree overlay code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2017 15:55:07 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Frank Rowand <frowand.list@...il.com>
Cc:     Pantelis Antoniou <pantelis.antoniou@...sulko.com>,
        David Airlie <airlied@...ux.ie>, Jyri Sarha <jsarha@...com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 00/12] of: overlay: clean up device tree overlay code

On Fri, Oct 13, 2017 at 5:03 PM, Frank Rowand <frowand.list@...il.com> wrote:
> Hi Rob,
>
> On 10/02/17 20:53, frowand.list@...il.com wrote:
>> From: Frank Rowand <frank.rowand@...y.com>
>>
>> I have found the device tree overlay code to be difficult to read and
>> maintain.  This patch series attempts to improve that situation.
>>
>> The cleanup includes some changes visible to users of overlays.  The
>> only in kernel user of overlays is fixed up for those changes.  The
>> in kernel user is:
>>
>>    drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
>>
>> Following the cleanup patches are a set of patches to fix various
>> issues.
>>
>> The first five patches are intended to not make any functional
>> changes, and are segrated to ease review.
>>
>> Frank Rowand (12):
>>   of: overlay.c: Remove comments that state the obvious, to reduce
>>     clutter
>>   of: overlay.c: Convert comparisons to zero or NULL to logical
>>     expressions
>>   of: overlay: rename identifiers to more reflect what they do
>>   of: overlay: rename identifiers in dup_and_fixup_symbol_prop()
>>   of: overlay: minor restructuring
>>   of: overlay: detect cases where device tree may become corrupt
>>   of: overlay: expand check of whether overlay changeset can be removed
>>   of: overlay: loosen overly strict phandle clash check
>>   of: overlay: avoid race condition between applying multiple overlays
>>   of: overlay: simplify applying symbols from an overlay
>>   of: overlay: remove a dependency on device node full_name
>>   of: overlay: remove unneeded check for NULL kbasename()
>>
>>  Documentation/devicetree/overlay-notes.txt   |   12 +-
>>  drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c |   15 +-
>>  drivers/of/base.c                            |    2 +-
>>  drivers/of/dynamic.c                         |  137 +++-
>>  drivers/of/of_private.h                      |   10 +-
>>  drivers/of/overlay.c                         | 1024 ++++++++++++++++----------
>>  drivers/of/unittest.c                        |   80 +-
>>  include/linux/of.h                           |   33 +-
>>  8 files changed, 871 insertions(+), 442 deletions(-)
>>
>
> What is the status on this series?  Did I resolve all of the issues that
> you found?  Is there anything else I need to do?
>
> The last issue that I recall, was a question about "[PATCH 09/12] of: overlay:
> avoid race condition between applying multiple overlays", were you asked if
> of_resolve_phandles() could be moved into of_overlay_apply().  I sent an
> additional patch "[PATCH] of: overlay: move resolve phandles into
> of_overlay_apply()" [1] that applies on top of this series to do so.

Sorry, found my draft on [1] unsent.

> There is a trickle of new patches against the same files as in my
> series, so I would like to get my series applied sooner that later,
> if possible.

I've applied 1-8, but haven't pushed them out. I was hoping to do the
whole series at once.

Rob