linux-kernel - Re: [PATCH][V2] selinux: remove extraneous initialization of slots_used and max_chain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2017 18:42:19 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Stephen Smalley <sds@...ho.nsa.gov>,
        Eric Paris <eparis@...isplace.org>,
        James Morris <james.l.morris@...cle.com>,
        "Serge E . Hallyn" <serge@...lyn.com>,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        selinux@...ho.nsa.gov, linux-security-module@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][V2] selinux: remove extraneous initialization of
 slots_used and max_chain_len

On Sat, Oct 14, 2017 at 11:38 AM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> Variables slots_used and max_chain_len are being initialized to zero
> twice. Remove the second set of initializations in the for loop.
> Cleans up the clang warnings:
>
> Value stored to 'slots_used' is never read
> Value stored to 'max_chain_len' is never read
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  security/selinux/ss/hashtab.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Also merged, thanks.

> diff --git a/security/selinux/ss/hashtab.c b/security/selinux/ss/hashtab.c
> index bef7577d1270..e0443f4afea5 100644
> --- a/security/selinux/ss/hashtab.c
> +++ b/security/selinux/ss/hashtab.c
> @@ -150,7 +150,7 @@ void hashtab_stat(struct hashtab *h, struct hashtab_info *info)
>
>         slots_used = 0;
>         max_chain_len = 0;
> -       for (slots_used = max_chain_len = i = 0; i < h->size; i++) {
> +       for (i = 0; i < h->size; i++) {
>                 cur = h->htable[i];
>                 if (cur) {
>                         slots_used++;
> --
> 2.14.1

-- 
paul moore
www.paul-moore.com