linux-kernel - Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from of_platform_default_populate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59E53651.5070704@gmail.com>
Date:   Mon, 16 Oct 2017 15:44:33 -0700
From:   Frank Rowand <frowand.list@...il.com>
To:     Sudeep Holla <sudeep.holla@....com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Rob Herring <robh@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>
Subject: Re: [RESEND][PATCH 1/4] of: platform: populate /firmware/ node from
 of_platform_default_populate_init()

+ me

On 09/28/17 03:45, Sudeep Holla wrote:
> Since "/firmware" does not have its own "compatible" property as it's
> just collection of nodes representing firmware interface, it's sub-nodes
> are not populated during system initialization.
> 
> Currently different firmware drivers search the /firmware/ node and
> populate the sub-node devices selectively. Instead we can populate
> the /firmware/ node during init to avoid more drivers continuing to
> populate the devices selectively.
> 
> To generalize the solution this patch populates the /firmware/ node
> explicitly from of_platform_default_populate_init().
> 
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Rob Herring <robh@...nel.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> ---
>  drivers/of/platform.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> index ac15d0e3d27d..3a213a6aee89 100644
> --- a/drivers/of/platform.c
> +++ b/drivers/of/platform.c
> @@ -515,6 +515,10 @@ static int __init of_platform_default_populate_init(void)
>  			of_platform_device_create(node, NULL, NULL);
>  	}
>  
> +	node = of_find_node_by_path("/firmware");
> +	if (node)
> +		of_platform_populate(node, NULL, NULL, NULL);
> +
>  	/* Populate everything else. */
>  	of_platform_default_populate(NULL, NULL, NULL);
>  
>