linux-kernel - Re: [patch v4 2/3] platform/mellanox: mlxreg-hotplug: allow driver for ARM architecture

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Oct 2017 22:16:07 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Vadim Pasternak <vadimp@...lanox.com>
Cc:     "dvhart@...radead.org" <dvhart@...radead.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Jiří Pírko <jiri@...nulli.us>
Subject: Re: [patch v4 2/3] platform/mellanox: mlxreg-hotplug: allow driver
 for ARM architecture

On Tue, Oct 17, 2017 at 9:22 PM, Vadim Pasternak <vadimp@...lanox.com> wrote:
> It allows driver to run on x86 and ARM architecture based systems.
> And allows to specify hotplug device parameters through the device
> table tree files.
> Also some unnecessary includes are removed.

>  menuconfig MELLANOX_PLATFORM
>         bool "Platform support for Mellanox hardware"
> -       depends on X86 || COMPILE_TEST
> +       depends on (X86 && !OF_DYNAMIC) || ARM || COMPILE_TEST

I'm not sure I now understand why you need a tricky dependency chain here...

> +#if defined(CONFIG_OF_DYNAMIC) && !defined(CONFIG_COMPILE_TEST)

...and what's wrong with COMPILE_TEST here.

> +static int mlxreg_hotplug_of_device_create(struct mlxreg_hotplug_device *data)
> +{
> +       return of_update_property(data->np, &mlxreg_hotplug_device_en);
> +}
> +
> +static void
> +mlxreg_hotplug_of_device_destroy(struct mlxreg_hotplug_device *data)
> +{
> +       of_update_property(data->np, &mlxreg_hotplug_device_dis);
> +       of_node_clear_flag(data->np, OF_POPULATED);
> +}
> +#else

> +#endif

-- 
With Best Regards,
Andy Shevchenko