linux-kernel - Re: [PATCH] ipmi_si: Delete an error message for a failed memory allocation in try_smi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de4d7991-0b8f-4596-2e3b-0b93046dd6d1@acm.org>
Date:   Tue, 17 Oct 2017 15:47:04 -0500
From:   Corey Minyard <minyard@....org>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>,
        openipmi-developer@...ts.sourceforge.net
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ipmi_si: Delete an error message for a failed memory
 allocation in try_smi_init()

On 10/15/2017 03:36 PM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 15 Oct 2017 22:30:11 +0200
>
> Omit an extra message for a memory allocation failure in this function.

Thanks, queued for the next release.

-corey

> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>   drivers/char/ipmi/ipmi_si_intf.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 55e0c42bee4d..2aed46a6c49c 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2095,7 +2095,6 @@ static int try_smi_init(struct smi_info *new_smi)
>   	/* Allocate the state machine's data and initialize it. */
>   	new_smi->si_sm = kmalloc(new_smi->handlers->size(), GFP_KERNEL);
>   	if (!new_smi->si_sm) {
> -		pr_err(PFX "Could not allocate state machine memory\n");
>   		rv = -ENOMEM;
>   		goto out_err;
>   	}