linux-kernel - Re: [PATCH] pwm: meson: use generic compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171017220920.acjq6dr3ntf7xkid@rob-hp-laptop>
Date:   Tue, 17 Oct 2017 17:09:20 -0500
From:   Rob Herring <robh@...nel.org>
To:     Jerome Brunet <jbrunet@...libre.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Kevin Hilman <khilman@...libre.com>,
        Carlo Caione <carlo@...one.org>, linux-pwm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pwm: meson: use generic compatibles

On Fri, Oct 13, 2017 at 11:16:42AM +0200, Jerome Brunet wrote:
> The meson pwm driver seems to be compatible with more SoCs than
> initially thought. Let's use the most generic compatibles he have in
> DT instead of the gxbb specific ones
> 
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
>  Documentation/devicetree/bindings/pwm/pwm-meson.txt |  6 +++---
>  drivers/pwm/pwm-meson.c                             | 12 ++++++------
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-meson.txt b/Documentation/devicetree/bindings/pwm/pwm-meson.txt
> index 1ee81321c35e..439e05030553 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-meson.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-meson.txt
> @@ -3,8 +3,8 @@ Amlogic Meson PWM Controller
>  
>  Required properties:
>  - compatible: Shall contain "amlogic,meson8b-pwm"
> -                         or "amlogic,meson-gxbb-pwm"
> -                         or "amlogic,meson-gxbb-ao-pwm"
> +                         or "amlogic,meson-gx-pwm"
> +                         or "amlogic,meson-gx-ao-pwm"

I've already said the same on other patches, but so other 
maintainers see it, this seems like pointless, non-backwards compatible 
change.

Rob