linux-kernel - Re: scripts/checkpatch: Concatenated strings should use spaces between elements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1508280192.6530.31.camel@perches.com>
Date:   Tue, 17 Oct 2017 15:43:12 -0700
From:   Joe Perches <joe@...ches.com>
To:     Heinrich Schuchardt <xypron.glpk@....de>,
        Andy Whitcroft <apw@...onical.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: scripts/checkpatch: Concatenated strings should use spaces
 between elements

On Tue, 2017-10-17 at 23:17 +0200, Heinrich Schuchardt wrote:
> This patch creates a warning (CHECK)
> "Concatenated strings should use spaces between elements"
> 
> There are no concatenated strings here.

Yes, there are.

> (checkpatch is also used in the U-Boot project where wide strings
> occur in the EFI implementation.)
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>
> ---
>  test.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 test.c
> 
> diff --git a/test.c b/test.c
> new file mode 100644
> index 0000000000..dfd33cd765
> --- /dev/null
> +++ b/test.c
> @@ -0,0 +1,6 @@
> +#include <foo.h>
> +
> +void foo(void)
> +{
> +	test(L"\"");

In this case, L must be a constant string and you
are concatenating L and "\""