linux-kernel - Re: [RFC PATCH v3 3/5] drm/bridge/analogix: Do not use device's drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 17 Oct 2017 19:42:38 -0400
From:   "Jingoo Han" <jingoohan1@...il.com>
To:     "'Jeffy Chen'" <jeffy.chen@...k-chips.com>,
        <linux-kernel@...r.kernel.org>
Cc:     <dmitry.torokhov@...il.com>, <heiko@...ech.de>,
        <briannorris@...omium.org>, <rjw@...ysocki.net>,
        <dianders@...omium.org>, <tfiga@...omium.org>,
        <broonie@...nel.org>, <seanpaul@...omium.org>,
        "'Andrzej Hajda'" <a.hajda@...sung.com>,
        <dri-devel@...ts.freedesktop.org>,
        "'Caesar Wang'" <wxt@...k-chips.com>,
        "'David Airlie'" <airlied@...ux.ie>,
        "'Laurent Pinchart'" <Laurent.pinchart@...asonboard.com>,
        <linux-samsung-soc@...r.kernel.org>,
        "'Daniel Vetter'" <daniel.vetter@...ll.ch>,
        "'Seung-Woo Kim'" <sw0312.kim@...sung.com>,
        "'Inki Dae'" <inki.dae@...sung.com>,
        <linux-rockchip@...ts.infradead.org>,
        "'Kyungmin Park'" <kyungmin.park@...sung.com>,
        "'Krzysztof Kozlowski'" <krzk@...nel.org>,
        "'Kukjin Kim'" <kgene@...nel.org>,
        "'Tomeu Vizoso'" <tomeu.vizoso@...labora.com>,
        "'zain wang'" <wzz@...k-chips.com>,
        "'Archit Taneja'" <architt@...eaurora.org>,
        "'Joonyoung Shim'" <jy0922.shim@...sung.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        "'Marek Szyprowski'" <m.szyprowski@...sung.com>,
        "'Mark Yao'" <mark.yao@...k-chips.com>
Subject: Re: [RFC PATCH v3 3/5] drm/bridge/analogix: Do not use device's drvdata

On Tuesday, October 17, 2017 4:09 AM, Jeffy Chen wrote:
> 
> From: Tomasz Figa <tfiga@...omium.org>
> 
> The driver that instantiates the bridge should own the drvdata, as all
> driver model callbacks (probe, remove, shutdown, PM ops, etc.) are also
> owned by its driver struct. Moreover, storing two different pointer
> types in driver data depending on driver initialization status is barely
> a good practice and in fact has led to many bugs in this driver.
> 
> Let's clean up this mess and change Analogix entry points to simply
> accept some opaque struct pointer, adjusting their users at the same
> time to avoid breaking the compilation.
> 
> Signed-off-by: Tomasz Figa <tfiga@...omium.org>
> Signed-off-by: Jeffy Chen <jeffy.chen@...k-chips.com>
> Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

Acked-by: Jingoo Han <jingoohan1@...il.com>

Best regards,
Jingoo Han

> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 50 +++++++++--------
> -----
>  drivers/gpu/drm/exynos/exynos_dp.c                 | 26 ++++++-----
>  drivers/gpu/drm/rockchip/analogix_dp-rockchip.c    | 47
+++++++++++-------
> --
>  include/drm/bridge/analogix_dp.h                   | 19 ++++----
>  4 files changed, 73 insertions(+), 69 deletions(-)
>