lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Mon, 16 Oct 2017 20:13:54 +0800
From:   Luwei Kang <luwei.kang@...el.com>
To:     kvm@...r.kernel.org
Cc:     pbonzini@...hat.com, rkrcmar@...hat.com, tglx@...utronix.de,
        mingo@...hat.com, hpa@...or.com, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        Chao Peng <chao.p.peng@...ux.intel.com>,
        Luwei Kang <luwei.kang@...el.com>
Subject: [PATCH 8/9] KVM: x86: Implement Intel processor trace context switch

From: Chao Peng <chao.p.peng@...ux.intel.com>

Load/Store Intel processor trace register in context switch.
MSR IA32_RTIT_CTL is loaded/stored automatically from VMCS,
other MSRs are loaded/stored manaully.

Signed-off-by: Chao Peng <chao.p.peng@...ux.intel.com>
Signed-off-by: Luwei Kang <luwei.kang@...el.com>
---
 arch/x86/kvm/vmx.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 100 insertions(+)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 5e86b5d..3c9ce3e 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -2146,6 +2146,86 @@ static bool pt_pmi(void)
 	.pmi = pt_pmi,
 };
 
+static inline void pt_load_msr(struct pt_ctx *ctx, unsigned int addr_num)
+{
+	u32 i;
+
+	wrmsrl(MSR_IA32_RTIT_STATUS, ctx->status);
+	wrmsrl(MSR_IA32_RTIT_OUTPUT_BASE, ctx->output_base);
+	wrmsrl(MSR_IA32_RTIT_OUTPUT_MASK, ctx->output_mask);
+	wrmsrl(MSR_IA32_RTIT_CR3_MATCH, ctx->cr3_match);
+	for (i = 0; i < addr_num; i++)
+		wrmsrl(MSR_IA32_RTIT_ADDR0_A + i, ctx->addrs[i]);
+}
+
+static inline void pt_save_msr(struct pt_ctx *ctx, unsigned int addr_num)
+{
+	u32 i;
+
+	rdmsrl(MSR_IA32_RTIT_STATUS, ctx->status);
+	rdmsrl(MSR_IA32_RTIT_OUTPUT_BASE, ctx->output_base);
+	rdmsrl(MSR_IA32_RTIT_OUTPUT_MASK, ctx->output_mask);
+	rdmsrl(MSR_IA32_RTIT_CR3_MATCH, ctx->cr3_match);
+	for (i = 0; i < addr_num; i++)
+		rdmsrl(MSR_IA32_RTIT_ADDR0_A + i, ctx->addrs[i]);
+}
+
+/*
+ * host-guest mode: save host and load guest.
+ * guest mode: load guest only.
+ * host mode: just need disable processor trace because guest will not
+ *            touch it.
+ * system mode: do nothing.
+ */
+static void pt_guest_enter(struct vcpu_vmx *vmx)
+{
+	u64 ctl;
+
+	/*
+	 * Save host IA32_RTIT_CTL MSR and disable processor trace.
+	 * If the "Load IA32_RTIT_CTL on entry" is 1, IA32_RTIT_CTL.TraceEn
+	 * must be zero. Otherwish, VMCS control check will cause a
+	 * failed-VMentry.
+	 */
+	if (pt_mode == PT_MODE_HOST || pt_mode == PT_MODE_HOST_GUEST) {
+		rdmsrl(MSR_IA32_RTIT_CTL, ctl);
+		vmx->pt_desc.host.ctl = ctl;
+		if (ctl & RTIT_CTL_TRACEEN) {
+			ctl &= ~RTIT_CTL_TRACEEN;
+			wrmsrl(MSR_IA32_RTIT_CTL, ctl);
+		}
+	}
+
+	if (pt_mode == PT_MODE_HOST_GUEST) {
+		pt_save_msr(&vmx->pt_desc.host, vmx->pt_desc.addr_num);
+		pt_load_msr(&vmx->pt_desc.guest, vmx->pt_desc.addr_num);
+	}
+
+	if (pt_mode == PT_MODE_GUEST)
+		pt_load_msr(&vmx->pt_desc.guest, vmx->pt_desc.addr_num);
+}
+
+static void pt_guest_exit(struct vcpu_vmx *vmx)
+{
+	/*
+	 * When "Clear IA32_RTIT_CTL on exit" exit control is set to 1,
+	 * IA32_RTIT_CTL MSR will be cleared on VMexit after it hase been
+	 * saved. So we need to restore the status of IA32_RTIT_CTL MSR
+	 * in host and host-guest mode.
+	 */
+	if (pt_mode == PT_MODE_HOST_GUEST) {
+		pt_save_msr(&vmx->pt_desc.guest, vmx->pt_desc.addr_num);
+		pt_load_msr(&vmx->pt_desc.host, vmx->pt_desc.addr_num);
+		wrmsrl(MSR_IA32_RTIT_CTL, vmx->pt_desc.host.ctl);
+	}
+
+	if (pt_mode == PT_MODE_GUEST)
+		pt_save_msr(&vmx->pt_desc.guest, vmx->pt_desc.addr_num);
+
+	if (pt_mode == PT_MODE_HOST)
+		wrmsrl(MSR_IA32_RTIT_CTL, vmx->pt_desc.host.ctl);
+}
+
 static void vmx_save_host_state(struct kvm_vcpu *vcpu)
 {
 	struct vcpu_vmx *vmx = to_vmx(vcpu);
@@ -5648,6 +5728,13 @@ static int vmx_vcpu_setup(struct vcpu_vmx *vmx)
 		vmcs_write16(GUEST_PML_INDEX, PML_ENTITY_NUM - 1);
 	}
 
+	if (pt_mode == PT_MODE_GUEST || pt_mode == PT_MODE_HOST_GUEST) {
+		u32 eax, ebx, ecx, edx;
+
+		cpuid_count(0x14, 1, &eax, &ebx, &ecx, &edx);
+		vmx->pt_desc.addr_num = eax & 0x7;
+	}
+
 	return 0;
 }
 
@@ -5742,6 +5829,15 @@ static void vmx_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event)
 	update_exception_bitmap(vcpu);
 
 	vpid_sync_context(vmx->vpid);
+
+	if (pt_mode == PT_MODE_GUEST || pt_mode == PT_MODE_HOST_GUEST) {
+		memset(&vmx->pt_desc.host, 0, sizeof(vmx->pt_desc.host));
+		memset(&vmx->pt_desc.guest, 0, sizeof(vmx->pt_desc.guest));
+		/* Bit[6~0] are forced to 1, writes are ignored. */
+		vmx->pt_desc.guest.output_mask = 0x7F;
+		/* Clear the status of IA32_RTIT_CTL in VMCS guest state. */
+		vmcs_write32(GUEST_IA32_RTIT_CTL, 0);
+	}
 }
 
 /*
@@ -9419,6 +9515,8 @@ static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu)
 	    vcpu->arch.pkru != vmx->host_pkru)
 		__write_pkru(vcpu->arch.pkru);
 
+	pt_guest_enter(vmx);
+
 	atomic_switch_perf_msrs(vmx);
 	debugctlmsr = get_debugctlmsr();
 
@@ -9554,6 +9652,8 @@ static void __noclone vmx_vcpu_run(struct kvm_vcpu *vcpu)
 				  | (1 << VCPU_EXREG_CR3));
 	vcpu->arch.regs_dirty = 0;
 
+	pt_guest_exit(vmx);
+
 	/*
 	 * eager fpu is enabled if PKEY is supported and CR4 is switched
 	 * back on host, so it is safe to read guest PKRU from current
-- 
1.8.3.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ