linux-kernel - Re: [PATCH] scsi: nsp32: fix logic bug in error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq1wp3u1ord.fsf@oracle.com>
Date:   Mon, 16 Oct 2017 22:39:34 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Masanori Goto <gotom@...ian.or.jp>
Cc:     Arnd Bergmann <arnd@...db.de>,
        YOKOTA Hiroshi <yokota@...lab.is.tsukuba.ac.jp>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Hannes Reinecke <hare@...e.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: nsp32: fix logic bug in error handling


Masanori,

>> gcc-8 points out a logic error that has existed since the start
>> of the git history:
>>
>> drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi':
>> drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
>>   if(((phase & BUSMON_BSY) == 1) || (phase & BUSMON_SEL) == 1) {

Applied to 4.15/scsi-queue. Thanks, Arnd!

-- 
Martin K. Petersen	Oracle Linux Engineering