linux-kernel - Re: [PATCH v8 08/15] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Oct 2017 14:37:16 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Mario Limonciello <mario.limonciello@...l.com>
Cc:     kbuild-all@...org, dvhart@...radead.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        Andy Lutomirski <luto@...nel.org>, quasisec@...gle.com,
        pali.rohar@...il.com, rjw@...ysocki.net, mjg59@...gle.com,
        hch@....de, Greg KH <greg@...ah.com>,
        Alan Cox <gnomes@...rguk.ukuu.org.uk>,
        Mario Limonciello <mario.limonciello@...l.com>
Subject: Re: [PATCH v8 08/15] platform/x86: dell-smbios: Add a sysfs
 interface for SMBIOS tokens

Hi Mario,

[auto build test WARNING on platform-drivers-x86/for-next]
[also build test WARNING on v4.14-rc5 next-20171016]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mario-Limonciello/Introduce-support-for-Dell-SMBIOS-over-WMI/20171017-103109
base:   git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git for-next
config: i386-randconfig-x074-201742 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from include/linux/linkage.h:4:0,
                    from include/linux/kernel.h:6,
                    from drivers/platform/x86/dell-smbios.c:17:
   drivers/platform/x86/dell-smbios.c: In function 'location_show':
   drivers/platform/x86/dell-smbios.c:218:7: error: implicit declaration of function 'capable' [-Werror=implicit-function-declaration]
     if (!capable(CAP_SYS_ADMIN))
          ^
   include/linux/compiler.h:156:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/platform/x86/dell-smbios.c:218:2: note: in expansion of macro 'if'
     if (!capable(CAP_SYS_ADMIN))
     ^~
   drivers/platform/x86/dell-smbios.c:218:15: error: 'CAP_SYS_ADMIN' undeclared (first use in this function)
     if (!capable(CAP_SYS_ADMIN))
                  ^
   include/linux/compiler.h:156:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/platform/x86/dell-smbios.c:218:2: note: in expansion of macro 'if'
     if (!capable(CAP_SYS_ADMIN))
     ^~
   drivers/platform/x86/dell-smbios.c:218:15: note: each undeclared identifier is reported only once for each function it appears in
     if (!capable(CAP_SYS_ADMIN))
                  ^
   include/linux/compiler.h:156:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/platform/x86/dell-smbios.c:218:2: note: in expansion of macro 'if'
     if (!capable(CAP_SYS_ADMIN))
     ^~
   drivers/platform/x86/dell-smbios.c: In function 'value_show':
   drivers/platform/x86/dell-smbios.c:232:15: error: 'CAP_SYS_ADMIN' undeclared (first use in this function)
     if (!capable(CAP_SYS_ADMIN))
                  ^
   include/linux/compiler.h:156:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
   drivers/platform/x86/dell-smbios.c:232:2: note: in expansion of macro 'if'
     if (!capable(CAP_SYS_ADMIN))
     ^~
   cc1: some warnings being treated as errors

vim +/if +218 drivers/platform/x86/dell-smbios.c

   212	
   213	static ssize_t location_show(struct device *dev,
   214				     struct device_attribute *attr, char *buf)
   215	{
   216		int i;
   217	
 > 218		if (!capable(CAP_SYS_ADMIN))
   219			return -EPERM;
   220	
   221		i = match_attribute(dev, attr);
   222		if (i > 0)
   223			return scnprintf(buf, PAGE_SIZE, "%08x", da_tokens[i].location);
   224		return 0;
   225	}
   226	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29473 bytes)