linux-kernel - Re: [PATCH v4] mm, sysctl: make NUMA stats configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171017081402.y5kz5i6puxcgrmkv@dhcp22.suse.cz>
Date:   Tue, 17 Oct 2017 10:14:02 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     kemi <kemi.wang@...el.com>
Cc:     "Luis R . Rodriguez" <mcgrof@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Jonathan Corbet <corbet@....net>,
        Mel Gorman <mgorman@...hsingularity.net>,
        Johannes Weiner <hannes@...xchg.org>,
        Christopher Lameter <cl@...ux.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Vlastimil Babka <vbabka@...e.cz>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Dave <dave.hansen@...ux.intel.com>,
        Tim Chen <tim.c.chen@...el.com>,
        Andi Kleen <andi.kleen@...el.com>,
        Jesper Dangaard Brouer <brouer@...hat.com>,
        Ying Huang <ying.huang@...el.com>,
        Aaron Lu <aaron.lu@...el.com>,
        Proc sysctl <linux-fsdevel@...r.kernel.org>,
        Linux MM <linux-mm@...ck.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Linux API <linux-api@...r.kernel.org>
Subject: Re: [PATCH v4] mm, sysctl: make NUMA stats configurable

On Tue 17-10-17 16:03:44, kemi wrote:
> On 2017年10月17日 15:54, Michal Hocko wrote:
[...]
> > So basically any value will enable numa stats. This means that we would
> > never be able to extend this interface to e.g. auto mode (say value 2).
> > I guess you meant to check sysctl_vm_numa_stat == ENABLE_NUMA_STAT?
> > 
> 
> I meant to make it more general other than ENABLE_NUMA_STAT(non 0 is enough), 
> but it will make it hard to scale, as you said.
> So, it would be like this:
> 0 -- disable
> 1 -- enable
> other value is invalid.
> 
> May add option 2 later for auto if necessary:)

But if you allow to set 2 without EINVAL now then you cannot change it
in future.

-- 
Michal Hocko
SUSE Labs