lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 17 Oct 2017 11:11:20 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Dan Carpenter <dan.carpenter@...cle.com>, linux-doc@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] char/snsc: Delete unnecessary braces in five
 functions

>>  		/* ...or if we want to block, then do so here */
>> -		if (down_interruptible(&sd->sd_wbs)) {
>> +		if (down_interruptible(&sd->sd_wbs))
>>  			/* something went wrong with wait */
>>  			return -ERESTARTSYS;
>> -		}
>>  	}
> 
> Multi-line indents get parenthesis.

How do you think about to add such an expectation to the section
“3) Placing Braces and Spaces” in the document “coding-style.rst”?

Regards,
Markus

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ