linux-kernel - Re: [PATCH 2/2] Add HASH support for Exynos

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <26963b1f-9489-28e5-cd86-a1b145b2fb62@partner.samsung.com>
Date:   Tue, 17 Oct 2017 12:32:05 +0200
From:   Kamil Konieczny <k.konieczny@...tner.samsung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     linux-crypto@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
        "David S. Miller" <davem@...emloft.net>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Add HASH support for Exynos



On 17.10.2017 12:07, Krzysztof Kozlowski wrote:
> On Mon, Oct 16, 2017 at 7:43 PM, Kamil Konieczny
> <k.konieczny@...tner.samsung.com> wrote:
>> Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW.
>>[...]
>> +#if IS_ENABLED(CONFIG_CRYPTO_DEV_EXYNOS_HASH)
> 
> I missed that in v5 because you wrote it is fixed... but it was not.
> You still have #ifdef here. Please fix it:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst#n993

Thank you for link, I didn't get it then, now it is clear,
I will rewrite and send v7 of patch.

-- 
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland