linux-kernel - Re: [PATCH 1/2] mm: drop migrate type checks from has_unmovable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871sm2j92j.fsf@concordia.ellerman.id.au>
Date:   Tue, 17 Oct 2017 22:41:08 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     Michal Hocko <mhocko@...nel.org>, linux-mm@...ck.org
Cc:     Vlastimil Babka <vbabka@...e.cz>,
        Andrew Morton <akpm@...ux-foundation.org>,
        KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
        Reza Arbab <arbab@...ux.vnet.ibm.com>,
        Yasuaki Ishimatsu <yasu.isimatu@...il.com>,
        qiuxishi@...wei.com, Igor Mammedov <imammedo@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH 1/2] mm: drop migrate type checks from has_unmovable_pages

Michal Hocko <mhocko@...nel.org> writes:

> From: Michal Hocko <mhocko@...e.com>
>
> Michael has noticed that the memory offline tries to migrate kernel code
> pages when doing
>  echo 0 > /sys/devices/system/memory/memory0/online
>
> The current implementation will fail the operation after several failed
> page migration attempts but we shouldn't even attempt to migrate
> that memory and fail right away because this memory is clearly not
> migrateable. This will become a real problem when we drop the retry loop
> counter resp. timeout.
>
> The real problem is in has_unmovable_pages in fact. We should fail if
> there are any non migrateable pages in the area. In orther to guarantee
> that remove the migrate type checks because MIGRATE_MOVABLE is not
> guaranteed to contain only migrateable pages. It is merely a heuristic.
> Similarly MIGRATE_CMA does guarantee that the page allocator doesn't
> allocate any non-migrateable pages from the block but CMA allocations
> themselves are unlikely to migrateable. Therefore remove both checks.
>
> Reported-by: Michael Ellerman <mpe@...erman.id.au>
> Signed-off-by: Michal Hocko <mhocko@...e.com>

Thanks, that works for me.

Tested-by: Michael Ellerman <mpe@...erman.id.au>

cheers