linux-kernel - RE: [PATCH 3/4] char/tpm: Improve a size determination in nine functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8d37c0407a949c1abb35cfd79c17f58@infineon.com>
Date:   Tue, 17 Oct 2017 11:50:05 +0000
From:   <Alexander.Steffen@...ineon.com>
To:     <andriy.shevchenko@...ux.intel.com>,
        <elfring@...rs.sourceforge.net>, <linux-integrity@...r.kernel.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <benh@...nel.crashing.org>,
        <clabbe.montjoie@...il.com>, <jarkko.sakkinen@...ux.intel.com>,
        <jgunthorpe@...idianresearch.com>, <jsnitsel@...hat.com>,
        <kgold@...ux.vnet.ibm.com>, <mpe@...erman.id.au>,
        <nayna@...ux.vnet.ibm.com>, <paulus@...ba.org>,
        <PeterHuewe@....de>, <stefanb@...ux.vnet.ibm.com>
CC:     <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH 3/4] char/tpm: Improve a size determination in nine
 functions

> > Replace the specification of data structures by pointer dereferences
> > as the parameter for the operator "sizeof" to make the corresponding
> > size
> > determination a bit safer according to the Linux coding style
> > convention.
> 
> 
> This patch does one style in favor of the other.

I actually prefer that style, so I'd welcome this change :)

> At the end it's Jarkko's call, though I would NAK this as I think some
> one already told this to you for some other similar patch(es).
> 
> 
> I even would suggest to stop doing this noisy stuff, which keeps people
> busy for nothing.

Cleaning up old code is also worth something, even if does not change one bit in the assembly output in the end...

Alexander