linux-kernel - [PATCH] fat: remove redundant assignment of 0 to slots

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171017140258.22536-1-colin.king@canonical.com>
Date:   Tue, 17 Oct 2017 15:02:58 +0100
From:   Colin King <colin.king@...onical.com>
To:     OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] fat: remove redundant assignment of 0 to slots

From: Colin Ian King <colin.king@...onical.com>

The variable slots is being assigned a value of zero that is never
read, slots is being updated again a few lines later. Remove this
redundant assignment.
Cleans clang warning: Value stored to 'slots' is never read

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 fs/fat/dir.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/fat/dir.c b/fs/fat/dir.c
index 81cecbe6d7cf..b833ffeee1e1 100644
--- a/fs/fat/dir.c
+++ b/fs/fat/dir.c
@@ -291,7 +291,6 @@ static int fat_parse_long(struct inode *dir, loff_t *pos,
 		}
 	}
 parse_long:
-	slots = 0;
 	ds = (struct msdos_dir_slot *)*de;
 	id = ds->id;
 	if (!(id & 0x40))
-- 
2.14.1