linux-kernel - Re: [PATCH 3/4] kvm/arm64: simplify CC instrumentation opt-out

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171017145033.GL5886@lvm>
Date:   Tue, 17 Oct 2017 07:50:33 -0700
From:   Christoffer Dall <cdall@...aro.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        adech.fo@...il.com, aryabinin@...tuozzo.com,
        catalin.marinas@....com, christoffer.dall@...aro.org,
        dvyukov@...gle.com, linux-kbuild@...r.kernel.org,
        mark.zyngier@....com, mmarek@...e.com, will.deacon@....com,
        yamada.masahiro@...ionext.com
Subject: Re: [PATCH 3/4] kvm/arm64: simplify CC instrumentation opt-out

On Mon, Oct 16, 2017 at 02:24:39PM +0100, Mark Rutland wrote:
> Now that we can opt out of all instrumentation with a single option,
> make use of this in the KVM hyp code. Hopefully, this will also avoid
> fragility as new options are introduced.
> 
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Christoffer Dall <christoffer.dall@...aro.org>
> Cc: Marc Zyngier <mark.zyngier@....com>
> Cc: Will Deacon <will.deacon@....com>

Acked-by: Christoffer Dall <christoffer.dall@...aro.org>

> ---
>  arch/arm64/kvm/hyp/Makefile | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile
> index 14c4e3b14bcb..a8a212eb66f1 100644
> --- a/arch/arm64/kvm/hyp/Makefile
> +++ b/arch/arm64/kvm/hyp/Makefile
> @@ -22,7 +22,4 @@ obj-$(CONFIG_KVM_ARM_HOST) += s2-setup.o
>  # KVM code is run at a different exception code with a different map, so
>  # compiler instrumentation that inserts callbacks or checks into the code may
>  # cause crashes. Just disable it.
> -GCOV_PROFILE	:= n
> -KASAN_SANITIZE	:= n
> -UBSAN_SANITIZE	:= n
> -KCOV_INSTRUMENT	:= n
> +CC_INSTRUMENT	:= n
> -- 
> 2.11.0
>