linux-kernel - Re: [PATCH] mm/hmm: remove redundant variable align

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171017163148.GC2933@redhat.com>
Date:   Tue, 17 Oct 2017 12:31:49 -0400
From:   Jerome Glisse <jglisse@...hat.com>
To:     Colin King <colin.king@...onical.com>
Cc:     linux-mm@...ck.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/hmm: remove redundant variable align_end

On Tue, Oct 17, 2017 at 03:38:37PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable align_end is assigned a value but it is never read, so
> the variable is redundant and can be removed. Cleans up the clang
> warning: Value stored to 'align_end' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Jérôme Glisse <jglisse@...hat.com>

> ---
>  mm/hmm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/hmm.c b/mm/hmm.c
> index a88a847bccba..ea19742a5d60 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -803,11 +803,10 @@ static RADIX_TREE(hmm_devmem_radix, GFP_KERNEL);
>  
>  static void hmm_devmem_radix_release(struct resource *resource)
>  {
> -	resource_size_t key, align_start, align_size, align_end;
> +	resource_size_t key, align_start, align_size;
>  
>  	align_start = resource->start & ~(PA_SECTION_SIZE - 1);
>  	align_size = ALIGN(resource_size(resource), PA_SECTION_SIZE);
> -	align_end = align_start + align_size - 1;
>  
>  	mutex_lock(&hmm_devmem_lock);
>  	for (key = resource->start;
> -- 
> 2.14.1
>