linux-kernel - Re: [PATCH] staging: media: imx: fix inconsistent IS_ERR and PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f843da31-9b94-7344-1111-a1aaf861ad4c@gmail.com>
Date:   Tue, 17 Oct 2017 10:21:52 -0700
From:   Steve Longerbeam <slongerbeam@...il.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH] staging: media: imx: fix inconsistent IS_ERR and PTR_ERR



On 10/17/2017 10:19 AM, Gustavo A. R. Silva wrote:
> Fix inconsistent IS_ERR and PTR_ERR in csi_link_validate.
> The proper pointer to be passed as argument is sensor.
>
> This issue was detected with the help of Coccinelle.
>
> Reported-by: Julia Lawall<julia.lawall@...6.fr>
> Signed-off-by: Gustavo A. R. Silva<garsilva@...eddedor.com>
> ---
> This code was tested by compilation only.
>
>   drivers/staging/media/imx/imx-media-csi.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
> index 6d85611..2fa72c1 100644
> --- a/drivers/staging/media/imx/imx-media-csi.c
> +++ b/drivers/staging/media/imx/imx-media-csi.c
> @@ -989,7 +989,7 @@ static int csi_link_validate(struct v4l2_subdev *sd,
>   	sensor = __imx_media_find_sensor(priv->md, &priv->sd.entity);
>   	if (IS_ERR(sensor)) {
>   		v4l2_err(&priv->sd, "no sensor attached\n");
> -		return PTR_ERR(priv->sensor);
> +		return PTR_ERR(sensor);
>   	}
>   
>   	mutex_lock(&priv->lock);

Reviewed-by: Steve Longerbeam <steve_longerbeam@...tor.com>