linux-kernel - Re: [PATCH] mm: mark mm_pgtables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171018084021.ha3ftkbfn5cqqjm6@node.shutemov.name>
Date:   Wed, 18 Oct 2017 11:40:22 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Michal Hocko <mhocko@...e.com>, Jan Kara <jack@...e.cz>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Lorenzo Stoakes <lstoakes@...il.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: mark mm_pgtables_bytes() argument as const

On Wed, Oct 18, 2017 at 10:31:17AM +0200, Arnd Bergmann wrote:
> The newly introduced mm_pgtables_bytes() function has two
> definitions with slightly different prototypes. The one
> used for CONFIG_MMU=n causes a compile-time warning:
> 
> In file included from include/linux/kernel.h:13:0,
>                  from mm/debug.c:8:
> mm/debug.c: In function 'dump_mm':
> mm/debug.c:137:21: error: passing argument 1 of 'mm_pgtables_bytes' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
> 
> This changes it to be the same as the other one and avoid the
> warning.
> 
> Fixes: 7444e6ee9cce ("mm: consolidate page table accounting")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

The fix is already in mmots:

http://ozlabs.org/~akpm/mmots/broken-out/mm-consolidate-page-table-accounting-fix.patch

-- 
 Kirill A. Shutemov