linux-kernel - Re: [PATCH] perf tools: Fix crash on buildid-list with namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 Oct 2017 09:07:21 +0900
From:   Namhyung Kim <namhyung@...nel.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Jiri Olsa <jolsa@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>, kernel-team@....com,
        Thomas-Mich Richter <tmricht@...ux.vnet.ibm.com>,
        "linux-perf-use." <linux-perf-users@...r.kernel.org>,
        Hendrik Brueckner <brueckner@...ux.vnet.ibm.com>,
        Hari Bathini <hbathini@...ux.vnet.ibm.com>
Subject: Re: [PATCH] perf tools: Fix crash on buildid-list with namespace

On Tue, Oct 17, 2017 at 11:05:55AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 17, 2017 at 10:29:00PM +0900, Namhyung Kim escreveu:
> > Thomas reported that perf buildid-list gets a segfault due to NULL
> > pointer when he ran it on a data with namespace events.  It was because
> > the buildid_id__mark_dso_hit_ops lacks the namespace event handler and
> > perf_too__fill_default() didn't set it.
> 
> In these cases, next time I suggest you add a Fixes: tag, so that the
> stable@...nel.org guys can automatically figure out which kernels need
> this fix, in this case:
> 
> Fixes: f3b3614a284d ("perf tools: Add PERF_RECORD_NAMESPACES to include namespaces related info")

Ah right, will add next time.

> 
> The script I have for this even adds this CC line:
> 
> Cc: Hari Bathini <hbathini@...ux.vnet.ibm.com>
> 
> I'm adding it,

Thanks,
Namhyung