[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-id: <59E72177.8000603@samsung.com>
Date: Wed, 18 Oct 2017 18:40:07 +0900
From: Chanwoo Choi <cw00.choi@...sung.com>
To: Hans de Goede <hdegoede@...hat.com>,
MyungJoo Ham <myungjoo.ham@...sung.com>,
Guenter Roeck <linux@...ck-us.net>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Darren Hart <dvhart@...radead.org>,
Andy Shevchenko <andy@...radead.org>,
Peter Rosin <peda@...ntia.se>,
Mathias Nyman <mathias.nyman@...el.com>
Cc: linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
devel@...verdev.osuosl.org,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@...ux.intel.com>,
Sathyanarayanan Kuppuswamy Natarajan <sathyaosid@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org
Subject: Re: [PATCH v3 10/14] extcon: intel-int3496: Add support for
controlling the USB-role mux
On 2017년 10월 18일 18:14, Hans de Goede wrote:
> Hi,
>
> On 18-10-17 04:33, Chanwoo Choi wrote:
>> Hi Hans,
>>
>> On 2017년 09월 23일 03:37, Hans de Goede wrote:
>>> Cherry Trail SoCs have a built-in USB-role mux for switching between
>>> the host and device controllers, rather then using an external mux
>>> controller by a GPIO.
>>>
>>> There is a driver using the mux-subsys to control this mux, this
>>> commit adds support to the intel-int3496 driver to get a mux_controller
>>> handle for the mux and set the mux through the mux-subsys rather then
>>> through a GPIO.
>>>
>>> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
>>> ---
>>> Changes in v2:
>>> -Drop || COMPILE_TEST from Kconfig depends on, as we will now fail to
>>> compile on !X86
>>> -Minor code style tweaks
>>> ---
>>> drivers/extcon/Kconfig | 3 +-
>>> drivers/extcon/extcon-intel-int3496.c | 59 +++++++++++++++++++++++++++++++++++
>>> 2 files changed, 61 insertions(+), 1 deletion(-)
>>
>> Acked-by: Chanwoo Choi <cw00.choi@...sung.com>
>
> Note that there have been some comments on this series, and it
> is not sure yet how we are going to end up handling this. So
> please do not merge this yet, as we may end up with another
> solution.
Sure. I don't merge only this patch. After finishing the review
of this patchset, one maintainer apply all patches and then
send immutable pull request.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Powered by blists - more mailing lists