linux-kernel - Re: [PATCH] phy: Return NULL if the phy is optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <796c0230-d018-e3e0-23d3-9f5f2406e5e3@ti.com>
Date:   Wed, 18 Oct 2017 16:42:51 +0530
From:   Kishon Vijay Abraham I <kishon@...com>
To:     Maxime Ripard <maxime.ripard@...e-electrons.com>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: Return NULL if the phy is optional



On Monday 04 September 2017 06:23 PM, Maxime Ripard wrote:
> If we're trying to get a handle to an optional phy, then the phy framework
> being disabled shouldn't return an hard error.
> 
> Instead, return NULL just like phy_optional_get does when there's no phy
> provided in the DT.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>

merged, thanks!

-Kishon
> ---
>  include/linux/phy/phy.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
> index 78bb0d7f6b11..76487b8d74ea 100644
> --- a/include/linux/phy/phy.h
> +++ b/include/linux/phy/phy.h
> @@ -289,7 +289,7 @@ static inline struct phy *devm_phy_get(struct device *dev, const char *string)
>  static inline struct phy *devm_phy_optional_get(struct device *dev,
>  						const char *string)
>  {
> -	return ERR_PTR(-ENOSYS);
> +	return NULL;
>  }
>  
>  static inline struct phy *devm_of_phy_get(struct device *dev,
>