linux-kernel - Re: [PATCH] driver core: Make sure device detached from driver before deleting it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59E73BBF.5090609@rock-chips.com>
Date:   Wed, 18 Oct 2017 19:32:15 +0800
From:   jeffy <jeffy.chen@...k-chips.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
CC:     linux-kernel@...r.kernel.org, dmitry.torokhov@...il.com,
        heiko@...ech.de, briannorris@...omium.org, dianders@...omium.org,
        tfiga@...omium.org, broonie@...nel.org, seanpaul@...omium.org,
        thierry.reding@...il.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] driver core: Make sure device detached from driver before
 deleting it

Hi Rafael,

On 10/18/2017 07:11 PM, jeffy wrote:
>>
> my board has these devices:
> spi master device->spi child device->spi based pwm->pwm_bl
>
> and i add a device link to the pwm and pwm_bl, and got a warning about
> the pwm not unbound:
sorry, it happens when i try to unbind the spi child device, and it's 
warning about the consumer(pwm_bl) not unbound.
>
> static void device_links_purge(struct device *dev)
> {
> ...
>          list_for_each_entry_safe_reverse(link, ln,
> &dev->links.consumers, s_node) {
>                  WARN_ON(link->status != DL_STATE_DORMANT &&
>                          link->status != DL_STATE_NONE); <-- warning here!
>                  __device_link_del(link);
>          }

and i've send a new patch to reorder the device_links_purge() and 
bus_remove_device, thanks again :)