linux-kernel - Re: [PATCH v2] objtool: Print top level commands on incorrect usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171018120253.qbcykwl435gof3eg@treble>
Date:   Wed, 18 Oct 2017 07:02:53 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH v2] objtool: Print top level commands on incorrect usage

On Sat, Oct 14, 2017 at 08:17:54PM +0530, Kamalesh Babulal wrote:
> Print top-level objtool commands, along with the error on incorrect
> command line usage. Objtool command line parser exit's with code 129,
> for incorrect usage. Convert the cmd_usage() exit code also, to maintain
> consistency across objtool.
> 
> After the patch:
> $ ./objtool -j
> Unknown option: -j
> 
>  usage: objtool COMMAND [ARGS]
> 
>  Commands:
>    check   Perform stack metadata validation on an object file
>    orc     Generate in-place ORC unwind tables for an object file
> 
> $ echo $?
> 129
> 
> Cc: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
> ---
> v2:
>   - Changes to commit message only.

Acked-by: Josh Poimboeuf <jpoimboe@...hat.com>

-- 
Josh