linux-kernel - Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171018142328.GQ2106@mtr-leonro.local>
Date:   Wed, 18 Oct 2017 17:23:28 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     "Wei Hu (Xavier)" <xavier.huwei@...wei.com>
Cc:     lijun_nudt@....com, linux-rdma@...r.kernel.org, shaobohsu@....com,
        linuxarm@...wei.com, linux-kernel@...r.kernel.org,
        dledford@...hat.com, zhangxiping3@...wei.com, shaoboxu@....com,
        shaobo.xu@...el.com, "Liuyixian (Eason)" <liuyixian@...wei.com>,
        "Chenxin (Charles)" <charles.chenxin@...wei.com>
Subject: Re: [PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

On Wed, Oct 18, 2017 at 05:12:02PM +0800, Wei Hu (Xavier) wrote:
>
>
> On 2017/10/18 16:42, Wei Hu (Xavier) wrote:
> >
> >
> > On 2017/10/1 0:10, Leon Romanovsky wrote:
> > > On Sat, Sep 30, 2017 at 05:28:59PM +0800, Wei Hu (Xavier) wrote:
> > > > If the IOMMU is enabled, the length of sg obtained from
> > > > __iommu_map_sg_attrs is not 4kB. When the IOVA is set with the sg
> > > > dma address, the IOVA will not be page continuous. and the VA
> > > > returned from dma_alloc_coherent is a vmalloc address. However,
> > > > the VA obtained by the page_address is a discontinuous VA. Under
> > > > these circumstances, the IOVA should be calculated based on the
> > > > sg length, and record the VA returned from dma_alloc_coherent
> > > > in the struct of hem.
> > > >
> > > > Signed-off-by: Wei Hu (Xavier) <xavier.huwei@...wei.com>
> > > > Signed-off-by: Shaobo Xu <xushaobo2@...wei.com>
> > > > Signed-off-by: Lijun Ou <oulijun@...wei.com>
> > > > ---
> > > Doug,
> > >
> > > I didn't invest time in reviewing it, but having "is_vmalloc_addr" in
> > > driver code to deal with dma_alloc_coherent is most probably wrong.
> > >
> > > Thanks
> > >
> > Hi, Doug
> >     When running in ARM64 platform, there probably be calltrace
> > currently.
> >     Now our colleague will report it to iommu maillist and try to solve
> > it.
> >     I also think RoCE driver shouldn't sense the difference.
> >     I will pull it out of this series and send v2.
> >     Thanks.
> >
> Hi, Doug & Leon
>     I have sent patch v2.
>     Thanks
>

Thanks

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)