linux-kernel - [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1508292283-140003-1-git-send-email-keescook@chromium.org>
Date:   Tue, 17 Oct 2017 19:04:40 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Jessica Yu <jeyu@...nel.org>
Cc:     Kees Cook <keescook@...omium.org>, Arnd Bergmann <arnd@...db.de>,
        linux-kernel@...r.kernel.org
Subject: [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param_call()

(re-sending to Jessica's @korg address...)

The module_param_call() macro was explicitly casting the .set and .get
function prototypes away with (void *). This can lead to hard-to-find
type mismatches. Additionally, it creates problems for static checkers
and Control Flow Itegrity compiler features, which depend on clustering
function call sites based on prototype signature.

This removes the casts and fixes all the incorrect prototypes tree-wide.

-Kees