linux-kernel - Re: [PATCH] checkpatch: Add TP_printk to list of logging functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2D45DA06-5A0D-4FC1-A451-6DD22D98E4DC@fb.com>
Date:   Wed, 18 Oct 2017 16:31:11 +0000
From:   Song Liu <songliubraving@...com>
To:     Joe Perches <joe@...ches.com>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Andy Whitcroft <apw@...onical.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Add TP_printk to list of logging functions


> On Oct 17, 2017, at 4:29 PM, Joe Perches <joe@...ches.com> wrote:
> 
> So the line length check can be bypassed by its callers.
> 
> Reported-by: Song Liu <songliubraving@...com>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 2a8c6c3c1bdb..359c02b0954e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -454,6 +454,7 @@ our $zero_initializer = qr{(?:(?:0[xX])?0+$Int_type?|NULL|false)\b};
> our $logFunctions = qr{(?x:
> 	printk(?:_ratelimited|_once|_deferred_once|_deferred|)|
> 	(?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
> +	TP_printk|
> 	WARN(?:_RATELIMIT|_ONCE|)|
> 	panic|
> 	MODULE_[A-Z_]+|
> -- 
> 2.10.0.rc2.1.g053435c
> 

Tested-by: Song Liu <songliubraving@...com>

Thanks for the fix!