linux-kernel - Re: [PATCH v7] PCI: Workaround wrong flags completions for IDT switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59E7B802.5010907@oracle.com>
Date:   Wed, 18 Oct 2017 16:22:26 -0400
From:   James Puthukattukaran <james.puthukattukaran@...cle.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
CC:     Sinan Kaya <okaya@...eaurora.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7] PCI: Workaround wrong flags completions for IDT switch

On 10/11/2017 03:27 PM, Bjorn Helgaas wrote:
> On Tue, Sep 26, 2017 at 04:03:13PM -0400, Sinan Kaya wrote:
>> On 9/26/2017 3:52 PM, James Puthukattukaran wrote:
>>>> I think you want to do the part above as part of a quirk that runs before
>>>> the probe.
>>>
>>> I don't think there's a way to run this early enough?
>>
>> Bjorn?
>>
>> I have seen multiple quirk types in quirks.c some prefixed with EARLY and
>> other LATE.
>
> I'm hoping an early quirk on the switch would be early enough, since
> the workaround needs to be done for devices downstream from the
> switch.
>

The problem is that this won't work for hotplug, which is where this bug 
is exposed. The issue is really moot for boot time since the requester 
id for down stream devices was "locked in" prior to enabling ACS  when 
the BIOS probes the devices present. So, this issue is for when a device 
is hotplugged downstream to this IDT switch.
James