lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Oct 2017 16:23:23 -0500 From: "Gustavo A. R. Silva" <garsilva@...eddedor.com> To: David Howells <dhowells@...hat.com> Cc: "David S. Miller" <davem@...emloft.net>, linux-afs@...ts.infradead.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: rxrpc: mark expected switch fall-throughs Quoting David Howells <dhowells@...hat.com>: > Gustavo A. R. Silva <garsilva@...eddedor.com> wrote: > >> + /* fall through */ > > All new comments in rxrpc should begin with a capital letter; I'm > switching to > this as I modify the lines with comments on. Fix checkpatch or gcc or > whatever takes -Wimplicit-fallthrough to stop being silly. > >> - /* Fall through */ >> - >> + /* fall through */ > > No. Firstly, it should be 'F'; secondly, don't remove the blank line - it's > there for a reason. > What is the reason? >> + /* fall through */ > > Capital 'F'. > >> - >> + /* fall through */ > > Don't remove the blank line. Capital 'F'. > >> + /* fall through */ > > Capital 'F'. > > David Thanks -- Gustavo A. R. Silva
Powered by blists - more mailing lists