linux-kernel - Re: [PATCH] of: overlay: pr_err from return NOTIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59E91DE0.5090106@gmail.com>
Date:   Thu, 19 Oct 2017 14:49:20 -0700
From:   Frank Rowand <frowand.list@...il.com>
To:     Rob Herring <robh+dt@...nel.org>, atull@...nel.org,
        pantelis.antoniou@...sulko.com,
        Pantelis Antoniou <panto@...oniou-consulting.com>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] of: overlay: pr_err from return NOTIFY_OK to overlay
 apply/remove

On 10/19/17 14:18, frowand.list@...il.com wrote:
> From: Frank Rowand <frank.rowand@...y.com>
> 
> A device tree overlay notifier can return NOTIFY_OK, NOTIFY_STOP,
> or an embedded errno.  overlay_notify() incorrectly reports an
> error for NOTIFY_OK.
> 
> Reported-by: atull@...nel.org
> Signed-off-by: Frank Rowand <frank.rowand@...y.com>
> ---
>  drivers/of/overlay.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> index c99842bb4b09..f5fce0fea40b 100644
> --- a/drivers/of/overlay.c
> +++ b/drivers/of/overlay.c
> @@ -133,7 +133,7 @@ static int overlay_notify(struct overlay_changeset *ovcs,
>  
>  		ret = blocking_notifier_call_chain(&overlay_notify_chain,
>  						   action, &nd);
> -		if (ret == NOTIFY_STOP)
> +		if (ret == NOTIFY_OK || ret == NOTIFY_STOP)
>  			return 0;
>  		if (ret) {
>  			ret = notifier_to_errno(ret);
> 

Not needed in any stable kernel.  This is caused by
"[PATCH v3 00/12] of: overlay: clean up device tree overlay code".

-Frank