linux-kernel - Re: [PATCH] perf test shell: trace+probe_libc_inet_pton.sh: force to use /bin/bash to load this script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbe5e8b5-a823-e6ee-47fc-5dfb0b1ae6c5@cn.fujitsu.com>
Date:   Thu, 19 Oct 2017 13:10:46 +0800
From:   Li Zhijian <lizhijian@...fujitsu.com>
To:     <linux-kernel@...r.kernel.org>, <peterz@...radead.org>,
        <mingo@...hat.com>, <acme@...nel.org>,
        <alexander.shishkin@...ux.intel.com>, <kim.phillips@....com>
CC:     <philip.li@...el.com>
Subject: Re: [PATCH] perf test shell: trace+probe_libc_inet_pton.sh: force to
 use /bin/bash to load this script

ignore this patch please, it will broken the test description which is read from the first line of this script

Thanks


On 10/19/2017 11:53 AM, Li Zhijian wrote:
> this script contains Array, but not all sh support Array. by default, dash provides sh at ubuntu/debian
> which can not support Array. so force to use /bin/bash
>
> it can fix following issue:
> lizhijian@...alhost:~/lkp/linux/tools/perf/tests/shell$ sudo ./trace+probe_libc_inet_pton.sh
> [sudo] password for lizhijian: PING ::1(::1) 56 data bytes
> ./trace+probe_libc_inet_pton.sh: 30: ./trace+probe_libc_inet_pton.sh: Bad substitution
> ./trace+probe_libc_inet_pton.sh: 32: ./trace+probe_libc_inet_pton.sh: Bad substitution
>
> Signed-off-by: Li Zhijian <lizhijian@...fujitsu.com>
> ---
>   tools/perf/tests/shell/trace+probe_libc_inet_pton.sh | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh b/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh
> index 7a84d73..df04cc1 100755
> --- a/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh
> +++ b/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh
> @@ -1,3 +1,5 @@
> +#!/bin/bash
> +
>   # probe libc's inet_pton & backtrace it with ping
>   
>   # Installs a probe on libc's inet_pton function, that will use uprobes,