linux-kernel - Re: [PATCH v2] static_key: Improve uninizialized key warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171019053327.526kfuuqopqlsg4o@gmail.com>
Date:   Thu, 19 Oct 2017 07:33:27 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Borislav Petkov <bp@...en8.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Hannes Frederic Sowa <hannes@...essinduktion.org>,
        Juergen Gross <jgross@...e.com>,
        Jason Baron <jbaron@...mai.com>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v2] static_key: Improve uninizialized key warning


* Steven Rostedt <rostedt@...dmis.org> wrote:

> On Wed, 18 Oct 2017 12:06:59 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> > > Signed-off-by: Borislav Petkov <bp@...e.de>
> > > Cc: Hannes Frederic Sowa <hannes@...essinduktion.org>
> > > Cc: Ingo Molnar <mingo@...nel.org>
> > > Cc: Juergen Gross <jgross@...e.com>
> > > Cc: "Steven Rostedt (VMware)" <rostedt@...dmis.org>  
> > 
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> > 
> 
> 
> Ingo, you may want to fix the typo in the subject "uninitialized".

Yeah, I also changed it to %pS to help debug arrays, or cases where somehow a 
non-data symbol ends up being passed to it. Plus I changed the message from:

  static_key_disable_cpuslocked, key virt_spin_lock_key used before call to jump_label_init.

to:

  static_key_disable_cpuslocked() static key 'virt_spin_lock_key' used before call to jump_label_init()

to make it all obviously readable. I mean, what if the symbol is named 'key' and 
we'd get confusing printouts like:

  static_key_disable_cpuslocked, key key used before call to jump_label_init.

Plus functions should be referred to with () to disambiguate them from other 
symbol names. Also, proper use of punctuation symbols.

Thanks,

	Ingo