linux-kernel - Re: [PATCH] input: touchscreen: ti_am335x_tsc: Fix incorrect step config for 5 wire touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171019002705.wrfz2ffioxjp2xu5@dtor-ws>
Date:   Wed, 18 Oct 2017 17:27:05 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Michael Nazzareno Trimarchi <michael@...rulasolutions.com>
Cc:     Vignesh R <vigneshr@...com>, linux-input@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>
Subject: Re: [PATCH] input: touchscreen: ti_am335x_tsc: Fix incorrect step
 config for 5 wire touchscreen

On Wed, Oct 18, 2017 at 07:18:11AM +0200, Michael Nazzareno Trimarchi wrote:
> Hi
> 
> On Tue, Sep 19, 2017 at 8:29 AM, Vignesh R <vigneshr@...com> wrote:
> > From: Jeff Lance <j-lance1@...com>
> >
> > Step config setting for 5 wire touchscreen is incorrect for Y coordinates.
> > It was broken while we moved to DT. If you look close at the offending
> > commit bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made
> > configurable"), the change was:
> >
> > - STEPCONFIG_XNP | STEPCONFIG_YPN;
> > + ts_dev->bit_xn | ts_dev->bit_yp;
> >
> > while bit_xn = STEPCONFIG_XNN and bit_yp = STEPCONFIG_YNN. Not quite the
> > same.
> >
> > Fixes: bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made configurable")
> > Signed-off-by: Jeff Lance <j-lance1@...com>
> > [vigneshr@...com: Rebase to v4.14-rc1]
> > Signed-off-by: Vignesh R <vigneshr@...com>
> > ---
> >
> > Tested on AM335x EVM with 5 wire tsc module. Also sanity tested
> > on a 4 wire tsc as well.
> >
> >  drivers/input/touchscreen/ti_am335x_tsc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
> > index 7953381d939a..f1043ae71dcc 100644
> > --- a/drivers/input/touchscreen/ti_am335x_tsc.c
> > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
> > @@ -161,7 +161,7 @@ static void titsc_step_config(struct titsc *ts_dev)
> >                 break;
> >         case 5:
> >                 config |= ts_dev->bit_xp | STEPCONFIG_INP_AN4 |
> > -                               ts_dev->bit_xn | ts_dev->bit_yp;
> > +                               STEPCONFIG_XNP | STEPCONFIG_YPN;
> >                 break;
> >         case 8:
> >                 config |= ts_dev->bit_yp | STEPCONFIG_INP(ts_dev->inp_xp);
> > --
> 
> Looks sane to me.

Applied, thank you.

> 
> Michael
> 
> > 2.14.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Dmitry