linux-kernel - RE: [PATCH] checkpatch: Introduce check for format of Fixes line in commit log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0502MB3008662D9D9D1BF80461C7CCD1420@VI1PR0502MB3008.eurprd05.prod.outlook.com>
Date:   Thu, 19 Oct 2017 05:52:41 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     Parav Pandit <parav@...lanox.com>,
        "joe@...ches.com" <joe@...ches.com>,
        "apw@...onical.com" <apw@...onical.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Brad Erickson <bradley@...lanox.com>
Subject: RE: [PATCH] checkpatch: Introduce check for format of Fixes line in
 commit log

Hi Joe,

> -----Original Message-----
> From: linux-rdma-owner@...r.kernel.org [mailto:linux-rdma-
> owner@...r.kernel.org] On Behalf Of Parav Pandit
> Sent: Tuesday, October 10, 2017 5:44 PM
> To: joe@...ches.com; apw@...onical.com
> Cc: linux-kernel@...r.kernel.org; linux-rdma@...r.kernel.org; Parav Pandit
> <parav@...lanox.com>; Brad Erickson <bradley@...lanox.com>
> Subject: [PATCH] checkpatch: Introduce check for format of Fixes line in commit
> log
> 
> This patch introduces a format check for 'Fixes' line in commit log for 12
> characters commit id and format for Fixes as ("...").
> 
> Its created against linux-rdma Doug's tree [1].
> 
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git
> 
> Signed-off-by: Parav Pandit <parav@...lanox.com>
> Signed-off-by: Brad Erickson <bradley@...lanox.com>
> ---
>  scripts/checkpatch.pl | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index
> dd2c262..7d933e4 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2548,6 +2548,14 @@ sub process {
>  			      "Remove Gerrit Change-Id's before submitting
> upstream.\n" . $herecurr);
>  		}
> 
> +# Check for incorrect format for Fixes line in commit log
> +		if ($in_commit_log && $line =~ /^\s*Fixes:/i) {
> +			if ($line !~ /^\s*Fixes: [a-z0-9]{12} \(\".*?\"\)$/i) {
> +				ERROR("FIXES_FORMAT",
> +				      "Follow format of Fixes: <12 characters
> commit id> (\"...\")\n" . $herecurr);
> +			}
> +		}
> +
>  # Check if the commit log is in a possible stack dump
>  		if ($in_commit_log && !$commit_log_possible_stack_dump &&
>  		    ($line =~ /^\s*(?:WARNING:|BUG:)/ ||
> --

Did you get a chance to review this minor improvement patch?
Does it look ok?
Can it be pushed to Linux-rdma tree?