linux-kernel - Re: [PATCH] clk: tegra: dfll: Fix drvdata overwriting issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 Oct 2017 10:23:10 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Nicolin Chen <nicoleotsuka@...il.com>
Cc:     pdeschrijver@...dia.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-clk@...r.kernel.org,
        jonathanh@...dia.com, sboyd@...eaurora.org,
        mturquette@...libre.com, pgaikwad@...dia.com
Subject: Re: [PATCH] clk: tegra: dfll: Fix drvdata overwriting issue

On Thu, Oct 12, 2017 at 04:09:59PM -0700, Nicolin Chen wrote:
> Both tegra124-dfll and clk-dfll are using platform_set_drvdata
> to set drvdata of the exact same pdev while they use different
> pointers for the drvdata. Once the drvdata has been overwritten
> by tegra124-dfll, clk-dfll will never get its td pointer as it
> expects.
> 
> Since tegra124-dfll merely needs its soc pointer in its remove
> function, this patch fixes the bug by removing the overwriting
> in the tegra124-dfll file and letting the tegra_dfll_unregister
> return an soc pointer for it.
> 
> Signed-off-by: Nicolin Chen <nicoleotsuka@...il.com>
> ---
> 
> As I don't have a T124 platform, I can't verify it on a board.
> If someone could provide a Tested-by, it would be very helpful.
> The test could be a simple system suspend/resume that activates
> runtime_suspend/resume() where a platform_get_drvdata() would
> be called. -- Nicolin
> 
>  drivers/clk/tegra/clk-dfll.c               | 10 +++++-----
>  drivers/clk/tegra/clk-dfll.h               |  2 +-
>  drivers/clk/tegra/clk-tegra124-dfll-fcpu.c | 12 +++++-------
>  3 files changed, 11 insertions(+), 13 deletions(-)

Applied, thanks.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)