linux-kernel - Re: [PATCH] EDAC, sb_edac: fix missing break in switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171019085721.yeqby35xrqfa4g4j@pd.tnic>
Date:   Thu, 19 Oct 2017 10:57:21 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Qiuxu Zhuo <qiuxu.zhuo@...el.com>, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC, sb_edac: fix missing break in switch

On Mon, Oct 16, 2017 at 12:40:29PM -0500, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> ---
>  drivers/edac/sb_edac.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index 72b98a0..f34430f 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -2485,6 +2485,7 @@ static int ibridge_mci_bind_devs(struct mem_ctl_info *mci,
>  		case PCI_DEVICE_ID_INTEL_IBRIDGE_IMC_HA0_TA:
>  		case PCI_DEVICE_ID_INTEL_IBRIDGE_IMC_HA1_TA:
>  			pvt->pci_ta = pdev;
> +			break;
>  		case PCI_DEVICE_ID_INTEL_IBRIDGE_IMC_HA0_RAS:
>  		case PCI_DEVICE_ID_INTEL_IBRIDGE_IMC_HA1_RAS:
>  			pvt->pci_ras = pdev;
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.