linux-kernel - Re: [PATCH 4.4 15/50] tty: goldfish: Fix a parameter of a call to free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171019093802.GF20059@kroah.com>
Date:   Thu, 19 Oct 2017 11:38:02 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Sasha Levin <alexander.levin@...izon.com>
Subject: Re: [PATCH 4.4 15/50] tty: goldfish: Fix a parameter of a call to
 free_irq

On Mon, Oct 16, 2017 at 08:46:06PM +0100, Ben Hutchings wrote:
> On Fri, 2017-10-06 at 10:53 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me
> > know.
> > 
> > ------------------
> > 
> > From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > 
> > 
> > [ Upstream commit 1a5c2d1de7d35f5eb9793266237903348989502b ]
> > 
> > 'request_irq()' and 'free_irq()' should be called with the same
> > dev_id.
> [...]
> 
> This fixes a bug introduced in 4.6 by commit 465893e18878 "tty:
> goldfish: support platform_device with id -1".  For earlier kernel
> versions, it *introduces* a bug.
> 
> Please revert from the 3.18 and 4.4 branches.

Ugh, the goldfish drivers are a pain lately...

I'll go revert this, luckily no one actually runs them in the tree :)

thanks,

greg k-h