linux-kernel - Re: [PATCH] driver core: Move device_links_purge() after bus_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59E7FBCC.4070201@rock-chips.com>
Date:   Thu, 19 Oct 2017 09:11:40 +0800
From:   jeffy <jeffy.chen@...k-chips.com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
CC:     linux-kernel@...r.kernel.org, seanpaul@...omium.irg,
        briannorris@...omium.org, heiko@...ech.de,
        gregkh@...uxfoundation.org, dmitry.torokhov@...il.com,
        dianders@...omium.org, tfiga@...omium.org, broonie@...nel.org,
        thierry.reding@...il.com
Subject: Re: [PATCH] driver core: Move device_links_purge() after bus_remove_device()

Hi Rafael,

On 10/19/2017 07:36 AM, Rafael J. Wysocki wrote:
> Why don't you write something like the following:
>
> "The current ordering of code in device_del() triggers a WARN_ON()
> in device_links_purge(), because of an unexpected link status.
>
> The device_links_unbind_consumers() call in device_release_driver()
> has to take place before device_links_purge() for the status of all
> links to be correct, so move the device_links_purge() call in
> device_del() after the invocation of bus_remove_device() which calls
> device_release_driver()."

that looks much better, i'll use it and your signed-off, thanks :)